Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#739: removed "not inside an IDE installation message" #753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonrohne27
Copy link
Contributor

Fixes: #739

Implements:

  • removed the message "you are not inside an IDE installation"

removed the message "you are not inside an IDE installation message"
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11795084200

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 82 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 67.28%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/context/AbstractIdeContext.java 82 60.19%
Totals Coverage Status
Change from base Build 11783967420: 0.01%
Covered Lines: 6397
Relevant Lines: 9166

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a small CR, please check.

Comment on lines 273 to 279
public String getMessageIdeHome() {

if (this.ideHome == null) {
return getMessageIdeHomeNotFound();
if (this.ideHome != null) {
return getMessageIdeHomeFound();
}
return getMessageIdeHomeFound();
return null;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method is not being used anymore. Can be removed I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Team Review
Development

Successfully merging this pull request may close these issues.

Replace red "You are not inside an IDE installation" message
3 participants